Thread (10 messages) 10 messages, 4 authors, 1d ago

Re: [PATCH net-next v23 3/3] net: phy: Add driver for Motorcomm Quad 2.5GbE phy

flat view

From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-10-01 15:33:18
Also in: linux-devicetree, lkml

On Thu,  1 Oct 2026 03:45:13 +0800 Kyle Switch wrote:
quoted hunk ↗ jump to hunk
+	/* 100M template amplitude */
+	ctrl = FIELD_PREP(YT8824_DAC_IMID_CH3_ORG, 0x45);
+	ctrl |= FIELD_PREP(YT8824_DAC_IMID_CH2_ORG, 0x45);
+	mask = YT8824_DAC_IMID_CH3_ORG | YT8824_DAC_IMID_CH3_ORG;
cocci says:

drivers/net/phy/motorcomm.c:1372:8-31: duplicated argument to & or |

Please also wait for the AI review to be published before reposting.
-- 
pw-bot: cr
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help