Thread (6 messages) 6 messages, 5 authors, 18d ago

Re: [PATCH net v4] net: mvneta: clear XDP pfmemalloc flag between frames

flat view

From: Lorenzo Bianconi <hidden>
Date: 2026-10-01 07:38:57
Also in: bpf

On Tue, 29 Sep 2026 15:43:03 +0200 Lorenzo Bianconi wrote:
quoted
mvneta_swbm_add_rx_fragment() sets XDP_FLAGS_FRAGS_PF_MEMALLOC on the
xdp_buff when a fragment page is a pfmemalloc one (page under memory
pressure). The xdp_buff is reused for the next frame, but only the
XDP_FLAGS_HAS_FRAGS bit was cleared at frame start, so the pfmemalloc
bit leaked from one frame into the following ones. mvneta_swbm_build_skb()
propagates the flag to skb->pfmemalloc through xdp_update_skb_frags_info(),
so the skb of a subsequent fragmented frame could be wrongly marked as
pfmemalloc even if none of its pages are under pressure.

Clear all the xdp_buff flags in mvneta_swbm_rx_frame(), which is invoked
for each new frame, instead of just the XDP_FLAGS_HAS_FRAGS bit.
Is there a reason you're not adding the info sinfo bot is asking for?
nope sorry :(. I have just forgot to reply. I will do next time.

Regards,
Lorenzo

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help