Re: 回覆: 回覆: [PATCH 0/5] net: ftgmac100: Add AST2700 support
flat view
From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-09-30 12:55:17
Also in:
linux-devicetree, lkml
quoted
Does your AST2700 bootloader also have the delays off by default?Yes. All of MACs in AST2700 are configured to disable RGMII delay with "rgmii-id".
static int ftgmac100_mii_probe(struct net_device *netdev)
{
struct ftgmac100 *priv = netdev_priv(netdev);
struct platform_device *pdev = to_platform_device(priv->dev);
struct device_node *np = pdev->dev.of_node;
struct phy_device *phydev;
phy_interface_t phy_intf;
int err;
if (!priv->mii_bus) {
dev_err(priv->dev, "No MDIO bus available\n");
return -ENODEV;
}
/* Default to RGMII. It's a gigabit part after all */
err = of_get_phy_mode(np, &phy_intf);
if (err)
phy_intf = PHY_INTERFACE_MODE_RGMII;
This default is now incorrect for the 2700.
I would suggest that for the 2700 you make phy-mode a required DT
property, and fail the probe if it is missing.
Andrew