[PATCH net-next 2/2] libie: log more info when virtchnl fails
HOTtoday
REVIEWED: 2 (0M)
From: Tony Nguyen <anthony.l.nguyen@intel.com>
Date: 2026-09-29 23:13:23
Subsystem:
intel ethernet drivers, libie common intel ethernet library, networking drivers, the rest · Maintainers:
Tony Nguyen, Przemek Kitszel, Alexander Lobakin, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
2 review trailers.
From: Li Li <redacted> Virtchnl failures can be hard to debug without logs. Logging the details of virtchnl transactions can be useful for debugging virtchnl-related issues. Tested: Built & booted on a test machine and synthetically produced a virtual failure to produce the following log: idpf 0000:01:00.0: Non-zero virtchnl ret val 6 (msg op: 1, data_len: 8); xn id: 0, cookie: 0 idpf 0000:01:00.0: Transaction failed (op 1, xn state: 3, id: 0, cookie: 0, size: 8) Signed-off-by: Li Li <redacted> Reviewed-by: Aleksandr Loktionov <redacted> Tested-by: Samuel Salin <redacted> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> --- drivers/net/ethernet/intel/libie/controlq.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
diff --git a/drivers/net/ethernet/intel/libie/controlq.c b/drivers/net/ethernet/intel/libie/controlq.c
index 6214fc036ce5..5fce6d9db1e2 100644
--- a/drivers/net/ethernet/intel/libie/controlq.c
+++ b/drivers/net/ethernet/intel/libie/controlq.c@@ -835,6 +835,13 @@ libie_ctlq_xn_process_recv(struct libie_ctlq_xn_recv_params *params, return false; } + if (ctlq_msg->chnl_retval) { + dev_err_ratelimited(params->ctlq->dev, + "Non-zero virtchnl ret val %u (msg op: %u, data_len: %u); xn id: %u, cookie: %u\n", + ctlq_msg->chnl_retval, ctlq_msg->chnl_opcode, + ctlq_msg->data_len, xn->index, xn->cookie); + } + if (xn->state != LIBIE_CTLQ_XN_ASYNC && xn->state != LIBIE_CTLQ_XN_WAITING) { spin_unlock(&xn->xn_lock);
@@ -1088,6 +1095,10 @@ int libie_ctlq_xn_send(struct libie_ctlq_xn_send_params *params) params->recv_mem = xn->recv_mem; break; default: + dev_err_ratelimited(params->ctlq->dev, + "Transaction failed (op %u, xn state: %u, id: %u, cookie: %u, size: %zu)\n", + params->chnl_opcode, xn->state, xn->index, + xn->cookie, xn->recv_mem.iov_len); ret = -EBADMSG; break; }
--
2.47.1