Re: [PATCH net] net: bcmgenet: if UMAC was suspended in SW_RESET, restore it to SW_RESET
flat view
From: Florian Fainelli <florian.fainelli@broadcom.com>
Date: 2026-09-29 20:12:55
On 9/29/26 12:22, Justin Chen wrote:
When the revised suspend/resume sequence was introduced this led to an edge
case where the TX is left disabled in the following sequence.
1. phy link is down, so UMAC is held in reset and then network interface
is WoL enabled
2. Enter suspend, bcmgenet_wol_power_down_cfg() enables UMAC_RX since MAC
is in SW_RESET
4. Enter resume, UMAC_RX is left enabled. Since we only enable UMAC_TX
and UMAC_RX in SW_RESET. The UMAC_TX is never enabled again on link up.
Fixes: 254f3239dd07 ("net: bcmgenet: revise suspend/resume")
Fixes: 88f6c8bf1aae ("net: bcmgenet: keep MAC in reset until PHY is up")
Signed-off-by: Justin Chen <justin.chen@broadcom.com>Excellent catch, thanks! Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> -- Florian