Re: [PATCH v2 2/4] net: qrtr: Assign unique node id for MHI endpoints
flat view
From: Manivannan Sadhasivam <mani@kernel.org>
Date: 2026-09-25 15:18:20
Also in:
ath11k, ath12k, linux-arm-msm, linux-wireless, lkml
On Fri, Sep 25, 2026 at 01:46:34PM +0100, Youssef Samir wrote:
On Thu, Sep 24, 2026 at 4:58 PM Manivannan Sadhasivam [off-list ref] wrote:quoted
On Wed, Sep 23, 2026 at 04:03:38PM +0100, Youssef Samir wrote:quoted
On Tue, Sep 22, 2026 at 6:24 PM Juha-Matti Tilli [off-list ref] wrote:quoted
On Tue, Sep 22, 2026, at 20:14, Youssef Samir wrote:quoted
On 9/21/2026 12:23 PM, Manivannan Sadhasivam via B4 Relay wrote:quoted
+The chance of collision is slim, but still not impossible.When you mean collision, do you mean node id collision due to bridged nodes? Because, even if the directly connected QAIC devices use 32bit node ids, the collision won't affect the functionality.As in ep_nid of one device matching the nid of another device. In MHI, that shouldn't really matter since this patch moves away from using QRTR_EP_NID_AUTO in node assignment, but as you mentioned below, it could clash with TUN and SMD EPs that are already registered with their ep_nid.
Ok, this clarifies. But as I mentioned before, there is no current usecase/requirement to support attaching identical SMD/TUN devices. When the requirement arises, we can extend this node id assignment scheme to global or some other method. - Mani -- மணிவண்ணன் சதாசிவம்