Re: [PATCH net v2] eth: fbnic: Keep real queue counts synchronized

From
Björn Töpel <bjorn@kernel.org>
Date
2026-09-25 12:54:32
Also in
lkml
Reply to
Breno Leitao, 2026-09-25
Breno!

Thanks for having a look!

Breno Leitao [off-list ref] writes:
Hello Björn,

On Thu, Sep 24, 2026 at 09:18:15PM +0200, Björn Töpel wrote:
quoted
If resume gets fewer vectors than the configured
layout needs, fail with -ENOSPC rather than silently change the queue
configuration and its bindings. The netdev then stays detached until a
later recovery or a device reprobe.
I am a bit surprised that I is better to get the device permanetly
disconnected other than just getting it running with fewer queues on
resume.
What's the queue selection policy?

 - Memory providers and AF_XDP                                                                          
 - RSS indirection and contexts                                                                         
 - ntuple rules                                                                                         
 - Queue leases                                                                                         
What is reprobing it later?
Nothing does it automatically. The netdev stays detached until a later
suspend/resume gets enough vectors, or until someone rebinds the driver.
A rebind resets the channels and drops the memory-provider bindings
anyway *shrug*.

This only happens when resume gets fewer MSI-X vectors than the
configured layout uses, for example when CPUs were offlined after the
channels were set.

...*is* this a real issue, or mostly theoretical?


Enjoy the weekend!
Björn
Thread (5 messages) 5 messages, 3 authors, last reply 2026-09-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help