Thread (2 messages) 2 messages, 2 authors, 4d ago

Re: [PATCH] net/sched: ematch: check nla_put_nohdr() return value in tcf_em_tree_dump()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2026-09-24 02:21:27
Also in: lkml

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski [off-list ref]:

On Sat, 19 Sep 2026 21:06:24 +0000 you wrote:
When tcf_em_tree_dump() was converted from the legacy rtnetlink
`RTA_PUT_NOHDR` macro (which contained an implicit `goto
rtattr_failure;`) to `nla_put_nohdr()`, the return value check on
`nla_put_nohdr()` was omitted for container/simple matches and raw match
payloads.

If the netlink dump skb runs out of tailroom at `nla_put_nohdr()`, the
error is silently ignored and `match_start->nla_len` is finalized
without the match payload, emitting a malformed/truncated
TCA_EMATCH_TREE_LIST attribute to userspace instead of returning `-1`
via `nla_put_failure` so rtnetlink can reallocate and retry the dump.

[...]
Here is the summary with links:
  - net/sched: ematch: check nla_put_nohdr() return value in tcf_em_tree_dump()
    https://git.kernel.org/netdev/net-next/c/528de6832b21

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help