Thread (7 messages) 7 messages, 3 authors, 7d ago

Re: [PATCH net v4 0/2] net/mlx5: Bridge, fix remaining switchdev ownership gaps on merged eswitch

From: patchwork-bot+netdevbpf@kernel.org
Date: 2026-09-23 01:21:16

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski [off-list ref]:

On Fri, 18 Sep 2026 10:59:29 +0100 you wrote:
v4 of "net/mlx5: Bridge, don't fail switchdev events of sibling
eswitch ports" (5f324c5d1b12), addressing reviewer feedback on v3:

 - The v3 commit message for patch 1 wrongly attributed the recursive
   lower-device walk fix to LAG bond enslavement order. As pointed
   out in review, mlx5_esw_bridge_lag_rep_get() already filters on
   mlx5_esw_bridge_dev_same_esw() per candidate and cannot select a
   sibling's rep. The actual bug is in the generic recursive walk
   used when attribute changes are emitted against the bridge master
   netdevice directly (a bridge with representors of more than one
   eswitch instance enslaved, no LAG involved): the walk returns as
   soon as any lower device yields a rep, and the underlying base
   case only checks same-HW, not ownership. Commit message rewritten
   to describe this correctly; no functional change from v3.
 - The v3 commit message for patch 2 claimed a "replayed/duplicate"
   NETDEV_CHANGEUPPER unlink as one of the reachable cases. As
   pointed out in review, netdevice notifiers are not replayed, so
   there is no such duplicate delivery. The actual (and only)
   reachable case is a sibling instance whose bridge offload notifier
   registers after a peer port was already enslaved, so it misses
   the link event and never tracks the port, then genuinely receives
   the later unlink event. Commit message rewritten accordingly; no
   functional change from v3.

[...]
Here is the summary with links:
  - [net,v4,1/2] net/mlx5: Bridge, don't fail switchdev events of sibling eswitch ports
    https://git.kernel.org/netdev/net/c/35e6f970f553
  - [net,v4,2/2] net/mlx5: Bridge, don't fail unlink of untracked/unsupported peer ports
    https://git.kernel.org/netdev/net/c/2e51097c982b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help