Thread (7 messages) 7 messages, 4 authors, 29d ago

RE: [PATCH net-next v4 3/3] net: ethernet: oa_tc6: add reset-gpios support

flat view

From: Selvamani Rajagopal <hidden>
Date: 2026-09-22 17:18:09
Also in: linux-devicetree, lkml

-----Original Message-----
From: Parthiban Veerasooran <parthiban.veerasooran@microchip.com>
Sent: Tuesday, September 22, 2026 2:00 AM
Also, do we still need oa_tc6_sw_reset_macphy() when reset_gpio is
implemented? My understanding is that the software reset path is mainly
needed for MAC-PHYs that do not expose a reset GPIO. In that case, it
may be cleaner to prefer the GPIO reset when available and fall back to
the software reset otherwise, rather than always performing both resets.
Register based reset inherently assumes that MACPHY responds to SPI 
read/write transactions. Here is one use case in using GPIO based reset in addition
to register based reset. One could implement a recovery mechanism when 
MACPHY locks up the SPI interface for some reason, 

As we know, the current code just sets disable_traffic flag to prevent the interface from 
working, when SPI transaction fails.
Best regards,
Parthiban V> /* Check the PROTE bit status so that we can reset
the device */
quoted
ret = oa_tc6_check_ctrl_protection(tc6);
if (ret) {
--
2.55.0
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help