Re: [PATCH] ppp: fix bsd_decompress() OOB read and ppp_decompress_frame() headroom check

On Sun, Sep 20, 2026 at 10:54:09PM +0000, netdev-bot+sashiko@kernel.org wrote:

Thank you for your contribution! Sashiko AI review found 4 potential
issue(s) to consider.

Critical: 0 · High: 1 · Medium: 3 · Low: 0

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [High] ppp_decompress_frame() (drivers/net/ppp/ppp_generic.c:2555-2557)
  now calls pskb_expand_head(skb, 2, 0, GFP_ATOMIC) unconditionally on…
- [Medium] The commit message states that the decompressed length 'is
  only checked for len < 0 before indexing ns->data[2..3] and calling…
- [Medium] The patch hardens only one of the three in-tree implementers
  of `struct compressor::decompress`.
- [Medium] The new pskb_expand_head(skb, 2, 0, GFP_ATOMIC) in
  ppp_decompress_frame() (drivers/net/ppp/ppp_generic.c:2556) creates…

Hi Hui,

There is an expectation that AI-generated reviews forwarded to
the netdev ML are responded to. That can take a variety of forms
including an email response that agrees with or refutes the review,
or an updated version of the patch with an appropriate changelog.

The expectation is the patch author or submitter handles this.  But in
order to move things along, I did take a look over these and taken together
it seems to me that these issues warrant a new revision of the patch.

Please keep in mind that distinct problems should be in separate patches,
and related patches should be bundled together in a patchset.

-- 
pw-bot: changes-requested