Re: [PATCH v3 2/4] nvme-tcp: unify sockopt with do_sock_setsockopt
flat view
From: Hannes Reinecke <hare@suse.de>
Date: 2026-09-21 13:34:02
Also in:
linux-nvme, mptcp
On 8/16/26 2:59 AM, Geliang Tang wrote:
From: Geliang Tang <redacted> This patch consolidates socket option settings in nvme-tcp by utilizing the generic do_sock_setsockopt() helper for options including SO_LINGER, SO_PRIORITY, TCP_NODELAY, IP_TOS, SO_BINDTODEVICE, and TCP_SYNCNT. Compared to the target-side implementation, this patch additionally converts SO_BINDTODEVICE and TCP_SYNCNT to use the same unified mechanism. This change eliminates the need to export and use specialized helpers for each individual socket option. Signed-off-by: Geliang Tang <redacted> --- drivers/nvme/host/tcp.c | 55 +++++++++++++++++++++++++++++++++++------ 1 file changed, 47 insertions(+), 8 deletions(-)
Reviewed-by: Hannes Reinecke <hare@kernel.org> Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich