Re: [PATCH net 2/3] net: txgbe: keep MAC enabled for NCSI and WoL for SP devices

On Mon, Sep 21, 2026 at 10:22:49AM +0800, Jiawen Wu wrote:

On Sun, Sep 20, 2026 10:56 PM, Andrew Lunn wrote:

quoted

On Sun, Sep 20, 2026 at 04:51:13PM +0800, Jiawen Wu wrote:

quoted

The .mac_link_down() in phylink callback disable MAC TX unconditionally.
This is not suitable for devices using NCSI or WoL, where the MAC needs
to remain enbaled after the link goes down to support the corresponding
functionality.

Skip disabling MAC TX when the subsystem device ID indicates an NCSI or
WoL device. Keep the existing link-down handling for other devices.

NCSI i can understand, but phylink knows about WoL. This makes me
think your WoL code is broken. Please review it.

WoL functionality has not been implemented on txgbe.
I'll change to fix NCSI first, then support WoL later.

I actually think we need a better solution for NCSI. At the moment,
each MAC driver has some sort of hack. It would be much better to just
tell phylink, so it can do the correct thing, similar to what it does
for WoL.

    Andrew