Re: [PATCH net-next v3 2/2] net: bridge: fail link info that does not fit in a netlink attribute
flat view
From: Nikolay Aleksandrov <razor@blackwall.org>
Date: 2026-09-20 07:06:37
Also in:
bridge, intel-wired-lan, linux-s390
On 19/09/2026 16:43, Artem Lytkin wrote:
nla_len is a u16, and a port with enough VLANs, tunnels or MST entries makes the IFLA_AF_SPEC nest wrap, so userspace reads garbage. Same for the inner MST and CFM nests. Use nla_nest_end_safe() for all three and return -E2BIG with an extack on overflow. Dumps end with that error, notifications go through rtnl_set_sk_err() so listeners resync. Assisted-by: Claude:claude-opus-5 Signed-off-by: Artem Lytkin <redacted> --- net/bridge/br_netlink.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-)
You can add specific extack messages to the different dumping parts of br_fill_ifinfo so the user can identify exactly which one doesn't fit and get a more accurate error. More below...
quoted hunk ↗ jump to hunk
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index 855a46aec3a89..fbd91b86d4268 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br_netlink.c@@ -459,7 +459,7 @@ static int br_fill_ifinfo(struct sk_buff *skb, const struct net_bridge_port *port, u32 pid, u32 seq, int event, unsigned int flags, u32 filter_mask, const struct net_device *dev, - bool getlink) + bool getlink, struct netlink_ext_ack *extack) { u8 operstate = netif_running(dev) ? READ_ONCE(dev->operstate) : IF_OPER_DOWN;@@ -588,7 +588,8 @@ static int br_fill_ifinfo(struct sk_buff *skb, goto nla_put_failure; }
Before these you can call if (nla_nest_end_safe(skb, af) < 0) { }
in the vlan block and set a vlan-specific extack error message, in fact
you can do that after vlan info is dumped, then after vlan tunnels are dumped
and set specific messages depending on which one didn't fit.
nla_nest_end_safe updates nla_len but you can still append attributes
after it has been called
Then you have MRP, you can do the same there and so on.
quoted hunk ↗ jump to hunk
- nla_nest_end(skb, cfm_nest); + if (nla_nest_end_safe(skb, cfm_nest) < 0) + goto nla_nest_too_large;
This can set its own extack err message, e.g. CFM information exceeds the netlink attribute size limit
quoted hunk ↗ jump to hunk
} if ((filter_mask & RTEXT_FILTER_MST) &&@@ -608,20 +609,27 @@ static int br_fill_ifinfo(struct sk_buff *skb, if (err) goto nla_put_failure; - nla_nest_end(skb, mst_nest); + if (nla_nest_end_safe(skb, mst_nest) < 0) + goto nla_nest_too_large;
Same here but with MST
quoted hunk ↗ jump to hunk
} done: if (af) { - if (nlmsg_get_pos(skb) - (void *)af > nla_attr_size(0)) - nla_nest_end(skb, af); - else + if (nla_nest_end_safe(skb, af) < 0) + goto nla_nest_too_large; + if (!nla_len(af)) nla_nest_cancel(skb, af); } nlmsg_end(skb, nlh); return 0; +nla_nest_too_large: + NL_SET_ERR_MSG_MOD(extack, + "AF_SPEC info too large, use per-object dumps (e.g. RTM_GETVLAN)");
Just make sure here to use NL_SET_ERR_MSG_WEAK_MOD() so extack doesn't get overwritten
quoted hunk ↗ jump to hunk
+ nlmsg_cancel(skb, nlh); + return -E2BIG; + nla_put_failure: nlmsg_cancel(skb, nlh); return -EMSGSIZE;@@ -654,7 +662,8 @@ void br_info_notify(int event, const struct net_bridge *br, if (skb == NULL) goto errout; - err = br_fill_ifinfo(skb, port, 0, 0, event, 0, filter, dev, false); + err = br_fill_ifinfo(skb, port, 0, 0, event, 0, filter, dev, false, + NULL); if (err < 0) { /* -EMSGSIZE implies BUG in br_nlmsg_size() */ WARN_ON(err == -EMSGSIZE);@@ -693,7 +702,7 @@ int br_getlink(struct sk_buff *skb, u32 pid, u32 seq, return 0; return br_fill_ifinfo(skb, port, pid, seq, RTM_NEWLINK, nlflags, - filter_mask, dev, true); + filter_mask, dev, true, extack); } static int br_vlan_info(struct net_bridge *br, struct net_bridge_port *p,