Thread (2 messages) flat view 2 messages, 2 authors, 4d ago
COOLING4d REVIEWED: 2 (2M)

1 review trailer.

[PATCH net v2] net: xscale: publish the IXP46x PTP OF module alias

From: Pengpeng Hou <hidden>
Date: 2026-09-20 03:46:32
Also in: lkml
Subsystem: networking drivers, the rest · Maintainers: Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

The IXP46x PTP driver matches intel,ixp46x-ptp-timer via its OF table,
but does not export that table. A module build therefore lacks the OF
alias used to automatically load the timer driver.

Export the existing table without changing the matching or probe logic.

The issue was found by our static-analysis tool.

Fixes: e9e506221b42 ("ixp4xx_eth: Probe the PTP module from the device tree")
Reviewed-by: Simon Horman <horms@kernel.org>
Assisted-by: gpt 5
Signed-off-by: Pengpeng Hou <redacted>
---
Changes since v1:
https://lore.kernel.org/all/20260704122722.5715-1-pengpeng@iscas.ac.cn/ (local)
Rewrite the source-analysis explanation as requested by Jakub and
identify the PTP driver in the subject.

 drivers/net/ethernet/xscale/ptp_ixp46x.c |    1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/xscale/ptp_ixp46x.c b/drivers/net/ethernet/xscale/ptp_ixp46x.c
index 558c4f8d23f7..c805d1df5d4e 100644
--- a/drivers/net/ethernet/xscale/ptp_ixp46x.c
+++ b/drivers/net/ethernet/xscale/ptp_ixp46x.c
@@ -307,6 +307,7 @@ static const struct of_device_id ptp_ixp_match[] = {
 	},
 	{ },
 };
+MODULE_DEVICE_TABLE(of, ptp_ixp_match);
 
 static struct platform_driver ptp_ixp_driver = {
 	.driver = {
base-commit: 518e5b794c06c0f0eb40df3e202274a66202c137
-- 
2.50.1 (Apple Git-155)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help