Re: [PATCH net-next v2 3/3] selftests: drv-net: Add VLAN test

On 19.9.2026 00:12, Jakub Kicinski wrote:

On Fri, 18 Sep 2026 14:04:13 +0200 Nicolai Buchwitz wrote:

quoted

quoted

+LOCAL_IP = os.environ.get("VLAN_LOCAL_V4", "198.51.100.1")
+REMOTE_IP = os.environ.get("VLAN_REMOTE_V4", "198.51.100.2")

   LOCAL_IP = "198.51.100.1"
   REMOTE_IP = "198.51.100.2"

LOCAL_IP / REMOTE_IP are in the default network segment (vlan 0)
Here we need some "unused" IP subnet that we can assign without
conflicts. Getting it from the config would indeed be good, but
since this is the first use perhaps we should defer until it actually
bothers someone?

Fine with me. Having the the selftest in place is probably more useful
than re-spinning for sole config issues. Let's fix this once someone 
needs it.

[...]

Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>

Thanks,
Nicolai