RE: [PATCH net-next v2 02/12] ice: remove unused ICE_FD_FLUSH_REQ from PF state

-----Original Message-----
From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
Sent: Thursday, September 17, 2026 8:39 PM
To: davem@davemloft.net; kuba@kernel.org; pabeni@redhat.com;
edumazet@google.com; andrew+netdev@lunn.ch; netdev@vger.kernel.org
Cc: Marcin Szycik <redacted>; Nguyen, Anthony L
[off-list ref]; Loktionov, Aleksandr
[off-list ref]; Penigalapati, Sandeep
[off-list ref]; S, Ananth [off-list ref];
alexander.duyck@gmail.com; Rinitha, SX [off-list ref]
Subject: [PATCH net-next v2 02/12] ice: remove unused ICE_FD_FLUSH_REQ
from PF state

From: Marcin Szycik <redacted>

It's hard to tell what this flag was intended to represent. The commit
adding it only added a check that was always false, because the flag
is never set. There is no relevant comment and commit message doesn't
mention it. Therefore, it looks like it has always been unused. Remove
it.

Signed-off-by: Marcin Szycik <redacted>
Tested-by: Rinitha S <redacted> (A Contingent worker at
Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/ice/ice.h                | 1 -
 drivers/net/ethernet/intel/ice/ice_ethtool_ntuple.c | 3 ---
 2 files changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice.h

b/drivers/net/ethernet/intel/ice/ice.h
index cb7a73bbcd71..a56e9b7c4dad 100644

--- a/drivers/net/ethernet/intel/ice/ice.h
+++ b/drivers/net/ethernet/intel/ice/ice.h

@@ -302,7 +302,6 @@ enum ice_pf_state {
 	ICE_CFG_BUSY,
 	ICE_SERVICE_SCHED,
 	ICE_SERVICE_DIS,
-	ICE_FD_FLUSH_REQ,
 	ICE_OICR_INTR_DIS,		/* Global OICR interrupt disabled */
 	ICE_MDD_VF_PRINT_PENDING,	/* set when MDD event handle */
 	ICE_VF_RESETS_DISABLED,	/* disable resets during ice_remove

*/

diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool_ntuple.c

b/drivers/net/ethernet/intel/ice/ice_ethtool_ntuple.c
index 744cd0b82470..516b57ff3b1c 100644

--- a/drivers/net/ethernet/intel/ice/ice_ethtool_ntuple.c
+++ b/drivers/net/ethernet/intel/ice/ice_ethtool_ntuple.c

@@ -1793,9 +1793,6 @@ int ice_del_ntuple_ethtool(struct ice_vsi *vsi,

struct ethtool_rxnfc *cmd)
 		return -EBUSY;
 	}

-	if (test_bit(ICE_FD_FLUSH_REQ, pf->state))
-		return -EBUSY;
-
 	mutex_lock(&hw->fdir_fltr_lock);
 	val = ice_ntuple_update_list_entry(pf, NULL, fsp->location);
 	mutex_unlock(&hw->fdir_fltr_lock);
--
2.47.1