Re: [PATCH net-next v15 4/4] net: dsa: ks8995: Delete surplus driver

On Thu, Sep 17, 2026 at 3:22 PM [off-list ref] wrote:

[Severity: Medium]
The commit message says the two in-tree boards "both use KS8995XA hardware
and continue to be supported by the replacement driver without regressions".
Is that description accurate with respect to tagging and port isolation?

The deleted driver used no switch tag and did not program the switch at all:

(...)

Removing that line makes the switch to the new tagging and port semantics
unavoidable. Could the commit message describe this behaviour change rather
than stating there are no regressions, given it also notes that the MA and E
variants were never verified with the replacement driver?

I don't think the exact wording of a commit message is that important.

I think this patch is good to go, I don't mind if the committer want
to change the commit message slightly though.

Like to the oneliner "delete the old driver" which should give none
of the above complaints from Sashiko.

Yours,
Linus Walleij