Re: [PATCH v15 net-next 1/2] octeontx2: use atomic bitops for PF/VF and rep flags
From: Paolo Abeni <pabeni@redhat.com>
Date: 2026-09-17 11:36:59
On 9/14/26 05:15, Ratheesh Kannoth wrote:
On 2026-09-12 at 16:26:28, sashiko-bot@kernel.org (sashiko-bot@kernel.org) wrote:quoted
Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider: Pre-existing issues: - [High] TC offload setup on representors corrupts the shared physical function (PF) device state by locklessly overwriting its netdev and clobbering its flags via a non-atomic bitwise sync loop. - [High] Inverted logic in `otx2_tc_del_flow()` prematurely disables TC MARK hardware offload when any single mark rule is deleted. - [High] Missing cancellation of `stats_wrk` leads to a Use-After-Free during representor teardown. - [High] `rvu_rep_mcam_flow_init()` interacts with the mailbox without acquiring its lock and executes an unbalanced `mutex_unlock()`. --I will address these in separate follow-up patches to the 'net' tree once this series is merged.
Note that the relevant sashiko instance for netdev is: https://netdev-ai.bots.linux.dev/sashiko/ Findings from such instance include the public ones, cross validates with additional LLM models. You can look exclusively to the nipa one. /P