Thread (3 messages) 3 messages, 3 authors, 9d ago

Re: [PATCH] net: phy: micrel: Advance register data pointer in write loop

From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-09-16 23:42:19
Also in: lkml, stable

On Wed, Sep 16, 2026 at 07:19:28PM -0400, Abhishek Ojha wrote:
lanphy_write_reg_data() does not advance the data pointer while iterating
over the register table. As a result, it writes the first entry num times
and leaves the remaining errata registers unconfigured.

Single-entry tables are unaffected, but tables with multiple entries
leave every entry after the first unapplied.

Advance the data pointer after each successful write so every table entry
is applied in order.

Fixes: c8732e933925 ("net: phy: micrel: lan8842 errata")
Cc: stable@vger.kernel.org
Signed-off-by: Abhishek Ojha <redacted>
Makes you wounder if the short_center_tap errata has any value.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help