Re: [PATCH] dmaengine: bestcomm: Enable compile testing

On Wed, Sep 16, 2026 at 1:25 PM Frank Li [off-list ref] wrote:

On Wed, Sep 16, 2026 at 12:47:52PM -0700, Rosen Penev wrote:

quoted

On Wed, Sep 16, 2026 at 12:42 PM Frank Li [off-list ref] wrote:

quoted

On Tue, Sep 15, 2026 at 11:17:09AM -0700, Rosen Penev wrote:

quoted

Allow the BestComm DMA engine to be selected for PowerPC
compile-test builds.

The freescale ethernet and sound drivers now need a dependency on
PPC_MPC52xx as they use headers/functions from that platform.

Assisted-by: LLM
Signed-off-by: Rosen Penev <redacted>
---
 drivers/dma/bestcomm/Kconfig           | 3 +--
 drivers/net/ethernet/freescale/Kconfig | 2 +-
 sound/soc/fsl/Kconfig                  | 2 +-
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/dma/bestcomm/Kconfig b/drivers/dma/bestcomm/Kconfig
index 5dd437295964..153b5492c93c 100644
--- a/drivers/dma/bestcomm/Kconfig
+++ b/drivers/dma/bestcomm/Kconfig

@@ -5,7 +5,7 @@

 config PPC_BESTCOMM
      tristate "Bestcomm DMA engine support"
-     depends on PPC_MPC52xx
+     depends on PPC_MPC52xx || (PPC && COMPILE_TEST)
      default n
      select PPC_LIB_RHEAP
      help

@@ -34,4 +34,3 @@ config PPC_BESTCOMM_GEN_BD
      depends on PPC_BESTCOMM
      help
        This option enables the support for the GenBD tasks.
-

diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
index b34c0fcfddea..d81984fcec64 100644
--- a/drivers/net/ethernet/freescale/Kconfig
+++ b/drivers/net/ethernet/freescale/Kconfig

@@ -38,7 +38,7 @@ config FEC

 config FEC_MPC52xx
      tristate "FEC MPC52xx driver"
-     depends on PPC_BESTCOMM
+     depends on PPC_BESTCOMM && PPC_MPC52xx

use seperate patch for difference subsystem.

The issue is this patch exposes the issue. It's also extremely
difficult to get anything into net without the maintainers claiming
this is pointless churn.

Maybe you try enable COMPILE_TEST for FEC_MPC52xx also

IIRC it compiles but does not link.

Frank

quoted

quoted

Frank

quoted

      select CRC32
      select PHYLIB
      select PPC_BESTCOMM_FEC

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 04940879dfd8..101bc952aa14 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig

@@ -234,7 +234,7 @@ config SND_SOC_MPC5200_I2S

 config SND_SOC_MPC5200_AC97
      tristate "Freescale MPC5200 PSC in AC97 mode driver"
-     depends on PPC_BESTCOMM
+     depends on PPC_BESTCOMM && PPC_MPC52xx
      select SND_SOC_AC97_BUS
      select SND_MPC52xx_DMA
      select PPC_BESTCOMM_GEN_BD
--

2.55.0