RE: [PATCH 16/28] pinctrl: samsung: Use snprintf() to construct pin bank names

-----Original Message-----
From: Bill Wendling <morbo@google.com>
Sent: Tuesday, September 15, 2026 10:19 AM
To: linux-kernel@vger.kernel.org
Cc: Bill Wendling <morbo@google.com>; codemender-
patching+linux@google.com; Russell King [off-list ref];
Huacai Chen [off-list ref]; WANG Xuerui [off-list ref];
Thomas Bogendoerfer [off-list ref]; James E.J. Bottomley
[off-list ref]; Helge Deller [off-list ref];
Thomas Gleixner [off-list ref]; Ingo Molnar [off-list ref];
Borislav Petkov [off-list ref]; Dave Hansen
[off-list ref]; x86@kernel.org; H. Peter Anvin
[off-list ref]; Ian Abbott [off-list ref]; H Hartley Sweeten
[off-list ref]; Luck, Tony [off-list ref];
Maarten Lankhorst [off-list ref]; Maxime Ripard
[off-list ref]; Thomas Zimmermann [off-list ref]; David
Airlie [off-list ref]; Simona Vetter [off-list ref]; Brost,
Matthew [off-list ref]; Thomas Hellström
[off-list ref]; Vivi, Rodrigo
[off-list ref]; Dmitry Torokhov [off-list ref];
Matthias Schwarzott [off-list ref]; Mauro Carvalho Chehab
[off-list ref]; Nguyen, Anthony L [off-list ref];
Kitszel, Przemyslaw [off-list ref]; Andrew Lunn
[off-list ref]; David S. Miller [off-list ref]; Eric
Dumazet [off-list ref]; Jakub Kicinski [off-list ref]; Paolo
Abeni [off-list ref]; Arend van Spriel
[off-list ref]; Rob Herring [off-list ref];
Saravana Kannan [off-list ref]; Krzysztof Kozlowski
[off-list ref]; Sylwester Nawrocki [off-list ref]; Peter
Griffin [off-list ref]; Alim Akhtar
[off-list ref]; Linus Walleij [off-list ref]; Anil
Gurumurthy [off-list ref]; Sudarsana Kalluru
[off-list ref]; Martin K. Petersen [off-list ref];
Trond Myklebust [off-list ref]; Anna Schumaker
[off-list ref]; Mike Marshall [off-list ref]; Martin
Brandenburg [off-list ref]; Kees Cook [off-list ref]; Jiri
Pirko [off-list ref]; Simon Horman [off-list ref]; Chuck Lever
[off-list ref]; Jeff Layton [off-list ref]; NeilBrown
[off-list ref]; Olga Kornievskaia [off-list ref]; Dai Ngo
[off-list ref]; Tom Talpey [off-list ref]; Jaroslav Kysela
[off-list ref]; Takashi Iwai [off-list ref]; Andrew Morton
[off-list ref]; Mike Rapoport (Microsoft)
[off-list ref]; Kanglong Wang [off-list ref]; Tiezhu
Yang [off-list ref]; Qiang Ma [off-list ref];
Randy Dunlap [off-list ref]; Pengpeng Hou
[off-list ref]; Ard Biesheuvel [off-list ref]; Breno Leitao
[off-list ref]; Thorsten Blum [off-list ref]; Harshit
Mogalapalli [off-list ref]; Greg Kroah-Hartman
[off-list ref]; Lyude Paul [off-list ref]; Ashutosh
Desai [off-list ref]; Deak, Imre [off-list ref];
Dmitry Baryshkov [off-list ref]; Johan Hovold
[off-list ref]; Berg, Johannes [off-list ref];
Korenblit, Miriam Rachel [off-list ref];
Alexander Stein [off-list ref]; Cryolitia PukNgae
[off-list ref]; Jiaming Zhang [off-list ref]; Will
Porter [off-list ref]; Cen Zhang [off-list ref];
Cássio Gabriel [off-list ref]; Rong Zhang
[off-list ref]; Arun Raghavan [off-list ref]; linux-arm-
kernel@lists.infradead.org; loongarch@lists.linux.dev; linux-
mips@vger.kernel.org; linux-parisc@vger.kernel.org; linux-
edac@vger.kernel.org; dri-devel@lists.freedesktop.org; intel-
xe@lists.freedesktop.org; linux-input@vger.kernel.org; linux-
media@vger.kernel.org; intel-wired-lan@lists.osuosl.org;
netdev@vger.kernel.org; linux-wireless@vger.kernel.org;
brcm80211@lists.linux.dev; brcm80211-dev-list.pdl@broadcom.com;
devicetree@vger.kernel.org; linux-samsung-soc@vger.kernel.org; linux-
gpio@vger.kernel.org; linux-scsi@vger.kernel.org; linux-
nfs@vger.kernel.org; devel@lists.orangefs.org; linux-
hardening@vger.kernel.org; linux-sound@vger.kernel.org
Subject: [PATCH 16/28] pinctrl: samsung: Use snprintf() to construct
pin bank names

samsung_banks_node_get() constructs each pin bank node name by copying
bank->name with strscpy() and appending the suffix with strlcat().

In preparation for removing the deprecated strlcat() API[1], format
the node name in a single snprintf() call, which preserves the
existing truncation check against sizeof(node_name).

Link: https://github.com/KSPP/linux/issues/370 [1]
Cc: codemender-patching+linux@google.com
Assisted-by: Gemini:Pro [editor_update_file,
make_kernel_build_single_file, checkpatch_run]
Signed-off-by: Bill Wendling <morbo@google.com>
---
Cc: Russell King <linux@armlinux.org.uk>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: WANG Xuerui <kernel@xen0n.name>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: Helge Deller <deller@gmx.de>
Cc: Thomas Gleixner <tglx@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Simona Vetter <simona@ffwll.ch>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Matthias Schwarzott <zzam@gentoo.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Saravana Kannan <saravanak@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Peter Griffin <peter.griffin@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: Linus Walleij <linusw@kernel.org>
Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
Cc: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
Cc: "Martin K. Petersen" <mkp@kernel.org>
Cc: Trond Myklebust <trondmy@kernel.org>
Cc: Anna Schumaker <anna@kernel.org>
Cc: Mike Marshall <hubcap@omnibond.com>
Cc: Martin Brandenburg <martin@omnibond.com>
Cc: Kees Cook <kees@kernel.org>
Cc: Jiri Pirko <jiri@resnulli.us>
Cc: Simon Horman <horms@kernel.org>
Cc: Chuck Lever <cel@kernel.org>
Cc: Jeff Layton <jlayton@kernel.org>
Cc: NeilBrown <neil@brown.name>
Cc: Olga Kornievskaia <okorniev@redhat.com>
Cc: Dai Ngo <Dai.Ngo@oracle.com>
Cc: Tom Talpey <tom@talpey.com>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: Bill Wendling <morbo@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
Cc: Kanglong Wang <redacted>
Cc: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Qiang Ma <redacted>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Pengpeng Hou <redacted>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Breno Leitao <leitao@debian.org>
Cc: Thorsten Blum <blum@kernel.org>
Cc: Harshit Mogalapalli <redacted>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Lyude Paul <lyude@redhat.com>
Cc: Ashutosh Desai <redacted>
Cc: Imre Deak <redacted>
Cc: Dmitry Baryshkov <redacted>
Cc: Johan Hovold <johan@kernel.org>
Cc: Johannes Berg <redacted>
Cc: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Cc: Alexander Stein <redacted>
Cc: Cryolitia PukNgae <cryolitia@uniontech.com>
Cc: Jiaming Zhang <redacted>
Cc: Will Porter <redacted>
Cc: Cen Zhang <redacted>
Cc: "Cássio Gabriel" <redacted>
Cc: Rong Zhang <redacted>
Cc: Arun Raghavan <redacted>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: loongarch@lists.linux.dev
Cc: linux-mips@vger.kernel.org
Cc: linux-parisc@vger.kernel.org
Cc: linux-edac@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Cc: linux-input@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
Cc: brcm80211@lists.linux.dev
Cc: brcm80211-dev-list.pdl@broadcom.com
Cc: devicetree@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Cc: linux-scsi@vger.kernel.org
Cc: linux-nfs@vger.kernel.org
Cc: devel@lists.orangefs.org
Cc: linux-hardening@vger.kernel.org
Cc: linux-sound@vger.kernel.org
---
 drivers/pinctrl/samsung/pinctrl-samsung.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c

b/drivers/pinctrl/samsung/pinctrl-samsung.c
index 5ecc9ed4c44d..0d639eec689c 100644

--- a/drivers/pinctrl/samsung/pinctrl-samsung.c
+++ b/drivers/pinctrl/samsung/pinctrl-samsung.c

@@ -1155,8 +1155,7 @@ static void samsung_banks_node_get(struct device

*dev, struct samsung_pinctrl_dr

 	bank = d->pin_banks;
 	for (i = 0; i < d->nr_banks; ++i, ++bank) {
-		strscpy(node_name, bank->name, sizeof(node_name));
-		len = strlcat(node_name, suffix, sizeof(node_name));
+		len = snprintf(node_name, sizeof(node_name), "%s%s",
bank->name,
+suffix);
 		if (len >= sizeof(node_name)) {
 			dev_err(dev, "Too long pin bank name '%s',
ignoring\n",
 				bank->name);
--
2.55.0.1032.g73a4cd73de-goog