Re: [PATCH net-next v14 1/4] dt-bindings: net: dsa: microchip: Add KSZ8995XA
From: netdev-bot+sashiko@kernel.org
Date: 2026-09-15 23:36:48
Also in:
linux-devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: Critical: 0 · High: 0 · Medium: 0 · Low: 1 - [Low] Concern (validated as resolved within the series): the new compatible `microchip,ksz8995xa` added to… -- dt-bindings: net: dsa: microchip: Add KSZ8995XA Adds the compatible string microchip,ksz8995xa to the Microchip KSZ series DSA switch binding, described as having the same properties as the KS8995XA. No Link: tags were present in the commit header.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml index 8d4a3a9a33fcc..4ed13870ed3ac 100644 --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml@@ -23,6 +23,7 @@ properties: - microchip,ksz8864 # 4-port version of KSZ8895 family switch - microchip,ksz8873 - microchip,ksz8895 # 5-port version of KSZ8895 family switch + - microchip,ksz8995xa
[Severity: Low]
One thing that came up while reviewing this in isolation: at this commit
there is no consumer for microchip,ksz8995xa, so a device tree using it
would not match anything in ksz_dt_ids[] in
drivers/net/dsa/microchip/ksz_spi.c and ksz_spi_probe() would bail out.
Checking the rest of the series resolves this, so this looks fine as is:
drivers/net/dsa/microchip/ksz_spi.c:ksz_dt_ids[]
{
.compatible = "microchip,ksz8995xa",
.data = &ksz_switch_chips[KSZ8995XA]
},
drivers/net/dsa/microchip/ksz_spi.c:ksz_spi_ids[]
{ "ksz8995xa" },
along with the ksz8995xa_regs[] register map and the KSZ8995XA entry in
ksz_switch_chips[] in drivers/net/dsa/microchip/ksz_common.c, all added by
"net: dsa: microchip: Support Microchip KSZ8995XA / KS8995XA". The
alternative placement in micrel,ks8995.yaml also does not apply since
drivers/net/dsa/ks8995.c is removed by "net: dsa: ks8995: Delete surplus
driver" in the same series.
Should the placement of the compatible with respect to the existing
allOf/if blocks be double checked too? The microchip,ksz8863/ksz8873
3-port block and the microchip,ksz8463 straps block both look inapplicable
to a 5-port KSZ8995XA, so as far as I can tell no existing conditional
needed the new string added, but confirmation would be useful.
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260914-ks8995-to-ksz8-v14-0-3d72692b3c97%40kernel.org