Re: [PATCH net v5] net: pcs: rzn1-miic: Fix config array initialization
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date: 2026-09-15 20:04:11
Also in:
linux-renesas-soc, lkml
On Tue, Sep 15, 2026 at 6:54 PM Kyle Hendry via B4 Relay [off-list ref] wrote:
From: Kyle Hendry <redacted>
Fix memset parameters to initialize the entire DT value array
Fixes: f39e968dc168a7bd ("net: pcs: rzn1-miic: Move configuration data to SoC-specific struct")
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Kyle Hendry <redacted>
---
Fix issues when populating dt_val array from device tree values
Changes in v5:
* Target memset patch for net
* Drop port number validation patch for later submission to net-next
Changes in v4: https://lore.kernel.org/r/20260914-rzn1-miic-fix-array-v4-0-069112feec86@reliablecontrols.com (local)
* Fix lines longer than 80 char
* Add of_node_put() before returning
Changes in v3: https://lore.kernel.org/r/20260902-rzn1-miic-fix-array-v3-0-3f7dccffaf5a@reliablecontrols.com (local)
* Make invalid port number return error
* Update commit tags
Changes in v2: https://lore.kernel.org/r/20260901-rzn1-miic-fix-array-v2-0-3e907049e770@reliablecontrols.com (local)
* Use a more correct array size in memset
* Ensure that write to dt_val is in range
Link to v1: https://lore.kernel.org/r/20260813-rzn1-miic-fix-array-v1-1-b58cafcc917e@reliablecontrols.com (local)
---
drivers/net/pcs/pcs-rzn1-miic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Cheers, Prabhakar
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c index 2b72fa98ddf1..cb74861e823c 100644 --- a/drivers/net/pcs/pcs-rzn1-miic.c +++ b/drivers/net/pcs/pcs-rzn1-miic.c@@ -683,7 +683,8 @@ static int miic_parse_dt(struct miic *miic, u32 *mode_cfg) if (!dt_val) return -ENOMEM; - memset(dt_val, MIIC_MODCTRL_CONF_NONE, sizeof(*dt_val)); + memset(dt_val, MIIC_MODCTRL_CONF_NONE, + sizeof(*dt_val) * miic->of_data->conf_conv_count); if (of_property_read_u32(np, "renesas,miic-switch-portin", &conf) == 0) dt_val[0] = conf;--- base-commit: 83a945a529d6e002dd7339c532288a931f463dba change-id: 20260813-rzn1-miic-fix-array-e6ae4452c017 Best regards, -- Kyle Hendry [off-list ref]