Re: [GIT PULL] bluetooth 2026-09-07
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2026-09-15 19:37:02
Also in:
linux-bluetooth
Hi Mark, On Tue, Sep 15, 2026 at 3:24 PM Mark Brown [off-list ref] wrote:
On Tue, Sep 15, 2026 at 03:16:21PM -0400, Luiz Augusto von Dentz wrote:quoted
On Tue, Sep 15, 2026 at 2:26 PM Mark Brown [off-list ref] wrote:quoted
quoted
Given the issues caused by the unusual workflow for the tree I do send a lot of reports of issues in bluetooth.quoted
Are you referring to the unusual workflow where fixes are merged to bluetooth-next first, then to bluetooth (which changes its ID), and finally merge to net? Changing the order to have Bluetooth first and then bluetooth-next would require reworking the CI so it could determine that it is a fix and then use Bluetooth as a base just to avoid ID changes.Yes, the routine cherry picking is certainly part of it - it's not so much the fact that things get moved between branches as the fact that when you have the same commit is in multiple branches and then build on top of one or both of them this creates extra conflicts, often harder to understand, when the branches are merged. The more normal thing would be to apply once to the right place, or the standard fallback from that would be to drop the commit from branch A at the time it is moved to branch B.
If I merge to bluetooth, then bluetooth-next won't contain the fixes meant for stable/rc, so I will need to merge them back to bluetooth-next immediately it order for our CI to stay current with the fixes.
You do seem to end up removing the cherry picked commits from their original branches at some point as part of your workflow (since there are hardly any duplicate bluetooth commits in mainline) so they do wind up being moves AFAICT but the duplicates get left sitting there for quite a while.
Yep, once before sending the pull request for net-next, bluetooth-next is rebased on top of net-next which brings all the fixes already merged back to bluetooth-next. Git is absolutely fine with that, I don't think I ever run into a conflict doing this. Git detects the fixes already present in net-next as duplicates and eliminates them, so it really surprises me when you say you are finding conflicts, not just duplicates. -- Luiz Augusto von Dentz