Re: [PATCH net] net: bcmgenet: restore the hardware filters on open

On 9/13/26 12:00, Nicolai Buchwitz wrote:

bcmgenet_hfb_init() runs INIT_LIST_HEAD() on priv->rxnfc_list, which drops
every rule off the list, and bcmgenet_open() calls it on each ifup. Every
rule the user configured is silently lost:

   # ethtool -N eth0 flow-type ether dst $MAC action 0
   Added rule with ID 0
   # ethtool -n eth0 | grep -c Filter:
   1
   # ip link set eth0 down && ip link set eth0 up
   # ethtool -n eth0 | grep -c Filter:
   0

Initialise the lists once at probe and restore the rules on open, as
bcmgenet_resume() already does.

Fixes: 3e370952287c ("net: bcmgenet: add support for ethtool rxnfc flows")
Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>

With the sashiko feedback addressed:

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian