Thread (42 messages) flat view 42 messages, 4 authors, 7d ago

Re: [PATCH net-next v11 06/15] ax88179_178a: Add HW support for AX179A-based chips

From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-09-14 16:54:08
Also in: linux-usb, lkml

quoted
+static const struct net_device_ops ax88179a_netdev_ops = {
+	.ndo_open		= usbnet_open,
+	.ndo_stop		= usbnet_stop,
+	.ndo_start_xmit		= usbnet_start_xmit,
+	.ndo_tx_timeout		= usbnet_tx_timeout,
+	.ndo_get_stats64	= dev_get_tstats64,
+	.ndo_change_mtu		= ax88179_change_mtu,
+	.ndo_set_mac_address	= ax88179_set_mac_addr,
+	.ndo_validate_addr	= eth_validate_addr,
+	.ndo_eth_ioctl		= usbnet_mii_ioctl,
dev->mii.mdio_read is never initialized for ax88179a, so
dev->mii.mdio_read()
through usbnet_mii_ioctl() is a NULL function pointer.

Something like:

  static int ax88179a_mii_ioctl(...)
  {
  	struct ax88179_data *data = netdev2data(net);
  	return phylink_mii_ioctl(data->phylink, ifr, cmd);
  }
Is this transitory? Does a later patch fix this up?
The aim is to remove all dev->mii accesses.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help