Re: [PATCH net v2] net: bridge: vlan: fix bugs caused by switchdev deletion errors
flat view
From: Ido Schimmel <idosch@nvidia.com>
Date: 2026-09-14 15:00:19
Also in:
bridge
On Mon, Sep 14, 2026 at 01:52:58PM +0300, Nikolay Aleksandrov wrote:
Allowing switchdev to prevent vlan deletion and error out in __vlan_del
could cause multiple different issues - inconsistent state, memory leaks
when flushing, NULL pointer dereference on bridge error when flushing.
It doesn't make sense to allow it to stop __vlan_del, so log the error
and continue with software vlan deletion. This is also consistent with
8021q behaviour.
Suggested-by: Ido Schimmel <idosch@nvidia.com>
Fixes: bf361ad38165 ("net: bridge: check __vlan_vid_del for error")
Fixes: 5454f5c28eca ("net: bridge: vlan: check for errors from __vlan_del in __vlan_flush")
Fixes: 2594e9064a57 ("bridge: vlan: add per-vlan struct and move to rhashtables")
Fixes: 9c86ce2c1ae3 ("net: bridge: Notify about bridge VLANs")
Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>Reviewed-by: Ido Schimmel <idosch@nvidia.com>