Re: [PATCH net-next v1 5/6] net: dsa: tag: mt7628: add VLAN awareness support

On Thu, Sep 10, 2026 at 12:17:28AM +0000, netdev-bot+sashiko@kernel.org wrote:

Thank you for your contribution! Sashiko AI review found 5 potential
issue(s) to consider:

Critical: 0 · High: 3 · Medium: 2 · Low: 0

- [High] mt7628_tag_xmit() (net/dsa/tag_mt7628.c:49-58) overwrites the
  two bytes at dsa_etype_header_pos_tx(skb) (skb->data + 2*ETH_ALEN)…
- [High] For a port under a VLAN-aware (filtering) bridge,
  mt7628_tag_xmit() only takes the new "modify TPID in place" path when…
- [High] mt7628_tag_xmit() (net/dsa/tag_mt7628.c:49-50) passes the result
  of dsa_port_bridge_dev_get(dp) straight into br_vlan_enabled(), which…
- [Medium] Both new code paths hardcode ETH_P_8021Q.
- [Medium] mt7628_tag_rcv() (net/dsa/tag_mt7628.c:115-116) re-inserts the
  switch-inserted VLAN tag as a hwaccel tag for every non-tag_8021q VID,…

[...]

Hi, thank you for the review. I was able to reproduce some of these
bugs. I will investigate the remaining ones and submit a fixed patchset.
Thanks,
Joris