Re: [PATCH v16 2/2] dt-bindings: net: Document Motorcomm YT8824 PHY package
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-09-11 08:44:24
Also in:
linux-devicetree, lkml
On Thu, Sep 10, 2026 at 03:46:24PM +0800, Kyle Switch wrote:
Document Motorcomm YT8824 PHY package. Motorcomm YT8824 Ethernet PHY is PHY package of 4 PHY-s.
One sentence is enough. "Document foo bar, a baz bam something".
Document the required property to make the PHY package correctly configure and work.
This is redundant sentence.
Signed-off-by: Kyle Switch <redacted> --- .../bindings/net/motorcomm,yt8824.yaml | 63 +++++++++++++++++++
Please organize the patch documenting the compatible (DT bindings) before the patch using that compatible. See also: https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46
quoted hunk ↗ jump to hunk
1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/motorcomm,yt8824.yamldiff --git a/Documentation/devicetree/bindings/net/motorcomm,yt8824.yaml b/Documentation/devicetree/bindings/net/motorcomm,yt8824.yaml new file mode 100644 index 000000000000..9907a4a7e63e --- /dev/null +++ b/Documentation/devicetree/bindings/net/motorcomm,yt8824.yaml@@ -0,0 +1,63 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/motorcomm,yt8824.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MotorComm YT8824 Ethernet PHY + +maintainers: + - Kyle Switch <kyle.switch@motor-comm.com> + +description: |
Do not need '|' unless you need to preserve formatting.
+ Motorcomm YT8824 Ethernet PHY is a PHY package of 4 PHYs. + +$ref: ethernet-phy-package.yaml# + +properties: + compatible: + enum: + - ethernet-phy-id4f51.e8b8 + + motorcomm,interface-mode:
Aren't you duplicating protocol-names from /schemas/phy/phy-common-props.yaml? Best regards, Krzysztof