Re: [PATCH net v4 7/7] selftests: drv-net: Add VLAN test
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-09-10 23:52:17
Also in:
linux-arm-kernel, linux-kselftest, lkml
On Thu, 10 Sep 2026 23:46:05 +0000 netdev-bot+sashiko@kernel.org wrote:
quoted
+@ksft_variants(_vlan_variants()) +def test(cfg, outer_proto, inner_proto, hw_strip): + """Run a single VLAN test""" + + cfg.require_ipver("4")[Severity: Low] Is this requirement needed? The test never uses the environment's IPv4 endpoint addresses: _vlan_setup() installs its own 198.51.100.1/24 and 198.51.100.2/24 on the newly created VLAN devices and the ping goes between those.
AI seems to be right, what we'd actually need here is
"require l2 connectivity" Let's leave it be for now,
just drop the require_ipver("4") and maybe we'll revisit
this when we also have the PHY related tests.
Could you break out the selftests to a separate series
for net-next? This posting seems to have conflicted with
other stmmac patches on the list and it'd be great to
run them a few times on our CI NICs before merging.