Thread (4 messages) 4 messages, 4 authors, 2026-09-10

Re: [PATCH net v2 1/1] tcp: reject non zerocopy devmem tx

flat view

From: Paolo Abeni <pabeni@redhat.com>
Date: 2026-09-10 12:44:32

On 9/9/26 5:57 PM, Mina Almasry wrote:
On Wed, Sep 9, 2026 at 6:45 AM [off-list ref] wrote:
quoted
Would it make sense to also reject dmabuf_id together with
MSG_FASTOPEN/DEFER_CONNECT and with repair-queue sends, or to teach
those paths about the binding?  The commit message mentions neither, so
it is hard to tell from the changelog whether these were considered,
which also matters for backporting given the two Fixes: tags.
Yes, I think we'd need to exclude MSG_FASTOPEN and DEFER_CONNECT.
Those are set by the userspace right? So it doesn't matter much if we
don't support them with devmem. Not sure how to correctly exclude
repair-queue sends.
FTR, I agree that the sashiko comments refers to a pre-existing and
different issue that should be addressed separately. I'm actually
quite surprised the model did not mark it as such.

/P
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help