Thread (2 messages) 2 messages, 2 authors, 2026-09-10

Re: [PATCH net] net: phylink: initialise link_state before a forced major config

flat view

From: patchwork-bot+netdevbpf@kernel.org
Date: 2026-09-10 01:51:07
Also in: lkml

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski [off-list ref]:

On Fri,  4 Sep 2026 18:55:40 +0000 you wrote:
phylink_resolve() leaves link_state on the stack unpopulated on its
disable and link-failed branches, which set only link_state.link.
phylink_apply_manual_flow() then reads the struct's advertising on
every mode but MLO_AN_FIXED, and has done so since long before
force_major_config existed.

force_major_config turns that into a write to the hardware. It is the
only trigger for the major-config block that does not require
mac_config, so phylink_major_config() programs the MAC for whatever
the stack held, a zeroed interface is PHY_INTERFACE_MODE_NA, and the
write-back stores it in pl->link_config.interface.

[...]
Here is the summary with links:
  - [net] net: phylink: initialise link_state before a forced major config
    https://git.kernel.org/netdev/net/c/113998aa372f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help