Re: [PATCH v4 net] octeontx2-pf: reset HTB scheduler topology before freeing queues

On Wed, Sep 09, 2026 at 08:47:10AM +0530, Ratheesh Kannoth wrote:

On 2026-09-08 at 22:37:40, netdev-bot+sashiko@kernel.org (netdev-bot+sashiko@kernel.org) wrote:

quoted

Thank you for your contribution! Sashiko AI review found 2 potential
issue(s) to consider:

Critical: 0 · High: 1 · Medium: 1 · Low: 0

- [High] Incomplete fix: the stale-TOPOLOGY bug class the commit claims
  to close stays reachable through the AF's bulk release path.

AF's built release path is FLR/PCI reset path. We will fix it as seperate fix.

quoted

- [Medium] Set/reset asymmetry at the aggregation level: HTB offload
  programs NIX_AF_TL1X_TOPOLOGY (PRIO_ANCHOR/RR_PRIO) on the shared per-…

We can't clear TL1 blindly as it is a shared resource between PF and VF.

Thanks for looking into those concerns, and moreover addressing Sashiko's
feedback on earlier revisions of this patch.

This version looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>

...