Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:
Critical: 0 · High: 0 · Medium: 0 · Low: 1
- [Low] Whitespace debris introduced by the patch:
afs_send_simple_reply() in fs/afs/rxrpc.c now contains two consecutive…
--
afs: Fix afs to abort the rxrpc call on send error
This makes afs_send_empty_reply() and afs_send_simple_reply() always try to
abort the rxrpc call on a send error instead of only aborting on -ENOMEM,
and makes afs_make_call() abort unconditionally on send error. The
afs_abort_oom trace enum is replaced by afs_abort_send_error.
Link: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260824091645.415423-1-dhowells%40redhat.com
quoted hunk ↗ jump to hunk
diff --git a/fs/afs/rxrpc.c b/fs/afs/rxrpc.c
index a80b043d36be4..04756d8744e2f 100644
--- a/fs/afs/rxrpc.c
+++ b/fs/afs/rxrpc.c
[ ... ]
quoted hunk ↗ jump to hunk
@@ -930,12 +920,9 @@ void afs_send_simple_reply(struct afs_call *call, const void *buf, size_t len)
return;
}
- if (n == -ENOMEM) {
- _debug("oom");
- rxrpc_kernel_abort_call(net->socket, call->rxcall,
- RXGEN_SS_MARSHAL, -ENOMEM,
- afs_abort_oom);
- }
+
+ rxrpc_kernel_abort_call(net->socket, call->rxcall,
+ RXGEN_SS_MARSHAL, n, afs_abort_send_error);
_leave(" [error]");
}
[Severity: Low]
This isn't a bug, but the removal of the -ENOMEM block seems to have left an
extra blank line behind in afs_send_simple_reply(). After the patch the
function reads:
if (n >= 0) {
/* Success */
_leave(" [replied]");
return;
}
rxrpc_kernel_abort_call(net->socket, call->rxcall,
RXGEN_SS_MARSHAL, n, afs_abort_send_error);
That is two consecutive blank lines, which checkpatch --strict flags with
"please don't use multiple blank lines". Since this patch carries
cc: <redacted>, would it be worth dropping the added blank line
so the backports don't inherit it? It is still present at the end of the
series.
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260907113743.1453210-1-dhowells%40redhat.com