Re: [PATCH 2/2] ieee802154: warn on unspecific wpan interface type
From: netdev-bot+sashiko@kernel.org
Date: 2026-09-08 18:20:39
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: Critical: 0 · High: 0 · Medium: 1 · Low: 0 - [Medium] The added WARN_ON fails to detect uninitialized iftypes because wpan_dev->iftype zero-initializes to NL802154_IFTYPE_NODE (0),… --
quoted hunk ↗ jump to hunk
diff --git a/net/ieee802154/core.c b/net/ieee802154/core.c --- a/net/ieee802154/core.c +++ b/net/ieee802154/core.c@@ -297,7 +297,7 @@ static int cfg802154_netdev_notifier_call(struct notifier_block *nb, rdev = wpan_phy_to_rdev(wpan_dev->wpan_phy); - /* TODO WARN_ON unspec type */ + WARN_ON(wpan_dev->iftype == NL802154_IFTYPE_UNSPEC); switch (state) { case NETDEV_POST_INIT:
[Severity: Medium] This check cannot fire for the case the commit message says it is meant to catch. In enum nl802154_iftype (include/uapi/linux/nl802154.h) NL802154_IFTYPE_UNSPEC is ~(__u32)0 while NL802154_IFTYPE_NODE is 0, so a wpan_dev whose iftype was never assigned - the struct lives in the zeroed netdev private area handed out by alloc_netdev(), and ieee802154_setup_sdata() is the only place that writes it - reads back as NL802154_IFTYPE_NODE, not UNSPEC. The WARN_ON in cfg802154_netdev_notifier_call() therefore only triggers if some caller explicitly stores UNSPEC (or -1, given wpan_dev->iftype is a plain int and the comparison promotes it to unsigned), which no in-tree code does. As written this is dead code rather than the assertion described. Note this is unlike cfg80211, where NL80211_IFTYPE_UNSPECIFIED is 0 and the same test does catch a zeroed field, so the pattern does not carry over directly. How do you want to handle this? Either the sanity check needs to be expressed in terms of a value that an uninitialized wpan_dev actually holds, or ieee802154_setup_sdata() and the other wpan_dev producers need to start out at NL802154_IFTYPE_UNSPEC so the warning has something to detect. Please also say whether you actually observed the condition, or whether this is intended purely as a future-proofing assertion. -- Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260905212007.304875-1-adrianox%40gmail.com