Re: [net PATCH 0/4] eth: fbnic: a collection of fixes

On 9/8/26 7:01 PM, Alexander Duyck wrote:

On Tue, Sep 8, 2026 at 2:41 AM Paolo Abeni [off-list ref] wrote:

quoted

I think some of the comments from sashiko (the high ones on patch 2 and
3) should be addressed in the same series.

Alex, please note that the current expectation is for the submitter to
treat sashiko comments alike to human reviewer's one, see commit
c82ff94592fb68f529afe63ca7f5ddb7dae4ba83.

Thanks. I will go through and address the comments. I assume that in
the cases where the AI is recommending something due to lacking
context I just need to add a comment or update the patch description
to provide the needed context?

Case in point being the AW_FLUSH_MODE and it asking about how we are
verifying the flush has occurred since it doesn't seem to grok that in
the same write that set it we cleared the BME so the device itself
cannot issue any more writes and the read completion essentially
clears the PCIe pipe.

I think in that case an additional code comment would be helpful. In
general an AI comment could be addressed with just a reply explaining
why the comment is off or is better addressed separately (quite alike
good old reviews :)

/P