Re: [PATCH 1/2] net: usb: cdc_ether: add NCSI passthrough support

On Tue, Sep 8, 2026 at 2:17 AM Andrew Lunn [off-list ref] wrote:

quoted

+/* NCSI operates at 100 Mbps */
+#define NCSI_SPEED_BPS               (100 * 1000000)

Why 100Mbps? RGMII is often used, running at 1G.

Since the original NC-SI specification was designed based on the
RMII protocol, simply set the speed to 100 Mbps as the default
for this virtual USB link.

quoted

+struct cdc_ncsi_priv {
+     struct ncsi_dev *ndev;
+     struct net_device_ops netdev_ops;
+     const struct net_device_ops *orig_netdev_ops;
+};
+
+static int cdc_ncsi_open(struct net_device *net);
+static int cdc_ncsi_stop(struct net_device *net);

No forward declarations. Move the code around so they are not needed.

Thanks for the suggestion, I will move the code to remove forward declarations.

   Andrew

Best regards,
Potin