Thread (7 messages) flat view 7 messages, 3 authors, 1d ago

Re: [PATCH net v2 0/2] net: macb: fix the link speed the taprio setup reads

From: patchwork-bot+netdevbpf@kernel.org
Date: 2026-09-08 10:01:07
Also in: lkml

Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni [off-list ref]:

On Thu,  3 Sep 2026 12:36:50 +0000 you wrote:
Two small fixes in macb_taprio_setup_replace(), both in how it obtains
the link speed it scales the schedule with.

The first: it hands phylink_ethtool_ksettings_get() a stack variable
it never zeroed, while phylink fills only what the link mode provides
and even reads one field back from the caller. The second: the speed
check is written as "<= 0" on a u32, so SPEED_UNKNOWN passes it and
turns into a 1 ns hardware limit that every entry then exceeds.

[...]
Here is the summary with links:
  - [net,v2,1/2] net: macb: zero the link settings taprio reads back
    https://git.kernel.org/netdev/net/c/0523d5c52a45
  - [net,v2,2/2] net: macb: reject an unknown link speed in the taprio setup
    https://git.kernel.org/netdev/net/c/2b6c0e25a3d7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help