Re: [PATCH net-next v9 3/4] net: dsa: microchip: Support Microchip KSZ8995XA / KS8995XA

Hi netdev-Sashiko,

new stuff every day! I like it :D

On Tue, Sep 8, 2026 at 5:49 AM [off-list ref] wrote:

[Severity: Low]
This isn't a bug, but should this loop use dev->phy_port_cnt rather than
dev->info->port_cnt?

Actually no. The boot loaders reset also the CPU port.

[Severity: Medium]
The commit message says:

  "Notice: there are also KSZ8995E and KSZ8995MA. These are BOTH
   different from the KSZ8995XA."

Given that, is it safe for family 0x95 with chip ID nibble 0x0 to be
mapped unconditionally to KSZ8995XA_CHIP_ID here?

Actually yes, all known users are the XA variant.

Whenever/if an MA user appear, we will deal with that then.
We have no hardware to test this as things are today.

Two in-tree device trees use the generic string today,
arch/arm/boot/dts/intel/ixp/intel-ixp42x-linksys-wrv54g.dts and
intel-ixp42x-actiontec-mi424wr.dtsi, so if MA behaves differently in
special-tag mode those boards would lose CPU-port traffic.

Those in-tree users are the XA variant, so this is a non-issue.

[Severity: Low]
Should the three Micrel strings also be added to the compatible enum in
Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml?

No. Device tree bindings are OS-neutral and do not change
because of Linux internal driver changes.

I will address the rest in v10.

Yours,
Linus Walleij