Thread (4 messages) 4 messages, 3 authors, 2026-09-08

Re: [PATCH net-next] selftests: icmp_redirect: remove xfail support

flat view

From: Hangbin Liu <hidden>
Date: 2026-09-08 02:40:34

On Mon, Sep 07, 2026 at 05:52:13PM +0200, Eric Dumazet wrote:
On Mon, Sep 7, 2026 at 5:37 PM Ido Schimmel [off-list ref] wrote:
quoted
Reviewed-by: Ido Schimmel <idosch@nvidia.com>

FTR, I don't think cd51b74bdd0b ("ipv6: Fix redirect exception creation
for UDP/RAW sockets") is what fixed the xfail (I never saw xfail, even
before my patch). It's more likely that it was fixed by commit
0e02bf5de46a ("selftests: icmp_redirect: IPv6 PMTU info should be
cleared after redirect"):

1. The redirect message quotes an echo request, so it's going through
icmpv6_err() which calls ip6_redirect() using the correct oif. It's
possible that rawv6_err() later called ip6_sk_redirect(), but by then
the exception was already present / populated.
Ah right,  I will send a V2 with an updated changelog, thanks!
Good, I will rebase my log_test() cleanup on your patch.

Thanks
Hangbin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help