Thread (11 messages) flat view 11 messages, 5 authors, 15d ago

Re: [PATCH net-next 2/3] netlink: specs: fou: local-v4 and peer-v4 are big endian

From: Nicolas Dichtel <hidden>
Date: 2026-09-07 10:05:07

Le 04/09/2026 à 21:14, Jakub Kicinski a écrit :
fou_core.c uses nla_get_in_addr() / nla_put_in_addr() on both, i.e.
they are __be32, and port / peer-port in the same spec are already
annotated. Without byte-order YNL swaps them on little endian hosts.

The generated policy goes from NLA_U32 to NLA_BE32, which changes
nothing: lib/nlattr.c gives the two the same length in nla_attr_len[]
and the same range handling, and neither attribute has a range check.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Nicolas Dichtel <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help