Re: [PATCH net-next 6/9] vxlan: dynamically allocate struct vxlan_config

On Mon, Sep 7, 2026 at 8:11 AM [off-list ref] wrote:

Thank you for your contribution! Sashiko AI review found 4 potential
issue(s) to consider:

Critical: 0 · High: 1 · Medium: 1 · Low: 2

- [High] vxlan_config_apply() publishes the newly allocated config with a
  plain store and immediately reclaims the old one with a bare kfree()…
- [Medium] The new configuration pointer is published with a plain store
  (vxlan_core.c:4038 `vxlan->cfg = new_cfg;`) right after the payload is…
- [Low] vxlan_encap_bypass() adds a `!dst_cfg` NULL test whose error
  branch (`goto drop`) lands on the `drop:` label, and that label passes…
- [Low] The patch introduces two mutually exclusive assumptions about
  vxlan->cfg for a live/registered netdev, on the same code paths.

For the record, I am ditching all Medium/Low reports from Sahiko.

One of Sashiko's suggestions led me to write an unnecessary patch,
which was a waste of time.