Re: [PATCH] zorro: use module_driver() to avoid repeated boilerplate code

From
Simon Horman <horms@kernel.org>
Date
2026-09-06 10:17:51
Also in
linux-scsi
Reply to
Ethan Nelson-Moore, 2026-09-06
On Sat, Sep 05, 2026 at 08:40:19PM -0700, Ethan Nelson-Moore wrote:
Many Zorro drivers have module_init and module_exit functions that only
call zorro_register_driver() and zorro_unregister_driver(). The
module_driver() macro automatically generates these functions given the
register and unregister functions. Switch to it to simplify the code.

Signed-off-by: Ethan Nelson-Moore <redacted>
---
 drivers/net/ethernet/8390/hydra.c     | 13 +------------
 drivers/net/ethernet/8390/zorro8390.c | 13 +------------
 drivers/net/ethernet/amd/a2065.c      | 13 +------------
 drivers/net/ethernet/amd/ariadne.c    | 13 +------------
 drivers/scsi/a2091.c                  | 12 +-----------
 drivers/scsi/gvp11.c                  | 12 +-----------
 drivers/scsi/zorro7xx.c               | 13 +------------
 drivers/scsi/zorro_esp.c              | 13 +------------
 8 files changed, 8 insertions(+), 94 deletions(-)
I think it would be best to split this patch up on a per-subsystem
of per driver basis. And send patches to appropriate subsystems.

In particular, please break out the net/ changes into a patchset
for net-next.

--
pw-bot: changes-requested
Thread (3 messages) 3 messages, 3 authors, last reply 2026-09-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help