Re: [PATCH net-next 0/4] selftests: openvswitch: pylint cleanup of ovs-dpctl.py

From
Minxi Hou <hidden>
Date
2026-09-06 08:55:53
Reply to
Minxi Hou, 2026-09-05
Hi all,

This series is a respin of the pylint cleanup I posted in May [1],
which got a changes-requested. I forgot to tag it as v2, sorry for
the confusion.

Changes since v1:

- Dropped the patch that renamed the NLA classes to snake_case. Those
  names mirror the kernel-side netlink attribute enums, so keeping
  them as-is makes the mapping obvious and avoids a large
  cosmetic-only diff.
- Rebased onto current net-next (base-commit 9eab111e7657).
- Pylint score is now 9.93/10 (upstream file scores 7.66/10).

On the direction Aaron raised in the v1 thread: moving ovs-dpctl.py
from pyroute2 to the in-tree YNL specs is still the right move, and
the gaps I listed back then (no ovs_packet.yaml or conntrack specs,
datapath flow operations and attributes missing from the family spec)
still stand. This cleanup is complementary to that migration: it
clears the mechanical noise now and shrinks the diff any future YNL
rewrite has to carry. Happy to pick up the migration discussion
separately, offline works for me.

[1] https://lore.kernel.org/netdev/20260513121240.2590767-1-houminxi@gmail.com/ (local)

Thanks,
Minxi
Thread (11 messages) 11 messages, 2 authors, last reply 2026-09-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help