Thread (7 messages) flat view 7 messages, 4 authors, 3d ago

Re: [PATCH net-next v3 2/2] 8021q: publish vlan_devices_arrays entries with acquire/release

From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-09-05 19:45:18
Also in: lkml

Some nits for the future..

On Wed, 2 Sep 2026 15:33:34 +0800 Jinjie Ruan wrote:
Replace the smp_wmb()/smp_rmb() barrier pair with
smp_store_release()/smp_load_acquire() on
vg->vlan_devices_arrays[pidx][vidx].

vlan_group_prealloc_vid() publishes the array pointer via release;
__vlan_group_get_device() acquires it before accessing the array,
ensuring the allocated entries are visible.

No functional change intended.
This phrase is usually reserved for patches which are pure refactor.
You are changing the barriers.
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>
Cc: Nicolai Buchwitz <redacted>
Cc: Stanislav Fomichev <sdf@fomichev.me>
Cc: Hangbin Liu <redacted>
Cc: Kuniyuki Iwashima <kuniyu@google.com>
Please put the CCs under the --- marker.
Assisted-by: DeepSeek:DeepSeek-V3
Signed-off-by: Jinjie Ruan <redacted>
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help