Re: [PATCH 1/2] ice: simplify ice_pf_state_is_nominal()
From: Simon Horman <horms@kernel.org>
Date: 2026-09-05 18:32:00
Also in:
intel-wired-lan, lkml
On Thu, Sep 03, 2026 at 09:20:35AM -0400, Yury Norov wrote:
The function creates a temporary mask on stack just to check that first ICE_STATE_NOMINAL_CHECK_BITS is empty. Simplify it by using the ice_pf_state_is_nominal().
maybe s/the ice_pf_state_is_nominal/bitmap_empty/
Signed-off-by: Yury Norov <redacted>
The above nit not withstanding this looks good to me. Reviewed-by: Simon Horman <horms@kernel.org>
quoted hunk ↗ jump to hunk
--- drivers/net/ethernet/intel/ice/ice_lib.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c index 9e08db376d3d..73996e3022ef 100644 --- a/drivers/net/ethernet/intel/ice/ice_lib.c +++ b/drivers/net/ethernet/intel/ice/ice_lib.c@@ -1705,16 +1705,10 @@ static void ice_vsi_set_rss_flow_fld(struct ice_vsi *vsi) */ bool ice_pf_state_is_nominal(struct ice_pf *pf) { - DECLARE_BITMAP(check_bits, ICE_STATE_NBITS) = { 0 }; - if (!pf) return false; - bitmap_set(check_bits, 0, ICE_STATE_NOMINAL_CHECK_BITS); - if (bitmap_intersects(pf->state, check_bits, ICE_STATE_NBITS)) - return false; - - return true; + return bitmap_empty(pf->state, ICE_STATE_NOMINAL_CHECK_BITS); } #define ICE_FW_MODE_REC_M BIT(1)-- 2.53.0