Re: [PATCH net-next 1/4] netlink: specs: dpll: add clock-quality-level to the device-get reply
From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Date: 2026-09-05 11:19:52
On 04/09/2026 20:10, Jakub Kicinski wrote:
quoted hunk ↗ jump to hunk
dpll_device_get_one() calls dpll_msg_add_clock_quality_level(), which puts DPLL_A_CLOCK_QUALITY_LEVEL into every device-get reply, dump entry and device-*-ntf of a device whose driver implements clock_quality_level_get() - mlx5 does. The &dev-attrs anchor lists 12 attributes and not this one, so struct dpll_device_get_rsp has no field for it, dpll_device_get_rsp_parse() drops it and dpll.rst does not document it. The attribute itself is correctly declared in the dpll attribute set, only the reply list was missing an entry. Missing since commit a1afb959add1 ("dpll: add clock quality level attribute and op"). Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- Documentation/netlink/specs/dpll.yaml | 1 + 1 file changed, 1 insertion(+)diff --git a/Documentation/netlink/specs/dpll.yaml b/Documentation/netlink/specs/dpll.yaml index cdc8c7b456df..64a45088c027 100644 --- a/Documentation/netlink/specs/dpll.yaml +++ b/Documentation/netlink/specs/dpll.yaml@@ -632,6 +632,7 @@ doc: DPLL subsystem. - mode-supported - lock-status - lock-status-error + - clock-quality-level - temp - clock-id - type
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>