Thread (20 messages) flat view 20 messages, 3 authors, 1d ago

Re: [PATCH net-next V3 13/15] selftests: drv-net: gro: Extract shared helpers into gro_lib.py

From: "Daniel Zahka" <daniel.zahka@gmail.com>
Date: 2026-09-04 12:34:56
Also in: bpf, linux-kselftest, linux-rdma, lkml

On Thu Sep 3, 2026 at 4:52 AM EDT, Tariq Toukan wrote:
From: Cosmin Ratiu <redacted>

Bits and pieces of gro.py are needed by a second test file:
- dmac resolution
- the ethtool/sysfs feature dance
- the HW GRO setup logic
- the gro binary invocation
- the retry loop

Move them to gro_lib.py, installed via TEST_FILES (like psp_lib.py).

hw/gro_hw.py keeps its own copies for now since they diverged.

Signed-off-by: Cosmin Ratiu <redacted>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
 tools/testing/selftests/drivers/net/Makefile  |   1 +
 tools/testing/selftests/drivers/net/gro.py    | 200 ++----------------
 .../testing/selftests/drivers/net/gro_lib.py  | 194 +++++++++++++++++
 3 files changed, 217 insertions(+), 178 deletions(-)
 create mode 100644 tools/testing/selftests/drivers/net/gro_lib.py
Conflicts with:
f225a7317c18 ("selftests: drv-net: split gro.py into one test per coalescing mode")

I will take a look at the other patches now in case I can provide any
feedback before reposting.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help