Re: [PATCH net-next v4] net: dsa: yt921x: Optimize driver for better generality.

On 9/2/26 20:29, Andrew Lunn wrote:

On Wed, Sep 02, 2026 at 10:47:37AM +0800, Kyle Switch wrote:

quoted

Replace fixed macros with values defined in series_info
for port validity checks, in order to facilitate future
adaptation to more switch series.

Replace all fixed values for DSA switch attributes with
values defined in series_info, to enable better scalability
across different switch families.

Signed-off-by: Kyle Switch <redacted>
---

v4:
1. Split patch into multiple patches

I still only see one patch. I was expecting to see a patch series of 5
to 10 patches.

This one patch still does multiple things. It needs splitting up.

Please subscribe to the netdev list. Spend 15 minutes every day
looking at other developers patches. Look at how they split up
changes. Read the review comments. Follow a patch series from v1
through to vX until it is merged. If you see review comments which
apply to your code, please fix up your own code.

You can learn a lot this way, it is worth the time and effort.

Ans: Thank you for your advice. I may have misunderstood

your earlier comment regarding patch splitting. In the v3 version,

we actually divided the patch into three parts: the tag, the DSA driver,

and another component. However, it appears that due to email

configuration problems, only the driver patch was delivered.

In any case, we will ensure that the patches are split by functionality

and post them accordingly.

     Andrew

---
pw-bot: cr